Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r129569091
  
    --- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
    @@ -548,22 +518,14 @@
         public static final String 
TOPOLOGY_AUTO_TASK_HOOKS="topology.auto.task.hooks";
     
         /**
    -     * The size of the Disruptor receive queue for each executor. Must be 
a power of 2.
    +     * The size of the receive queue for each executor.
          */
    -    @isPowerOf2
         public static final String 
TOPOLOGY_EXECUTOR_RECEIVE_BUFFER_SIZE="topology.executor.receive.buffer.size";
    --- End diff --
    
    If this does not need to be a power of 2 that is fine but we still want an 
annotation to say what type it is.  I think `@isPositiveNumber` is probably 
good enough.  You might want to make it an `@isInteger` too if you want to 
limit it to 32 bits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to