Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129732524
--- Diff: conf/defaults.yaml ---
@@ -231,16 +228,13 @@ topology.multilang.serializer:
"org.apache.storm.multilang.JsonSerializer"
topology.shellbolt.max.pending: 100
topology.skip.missing.kryo.registrations: false
topology.max.task.parallelism: null
-topology.max.spout.pending: null
+topology.max.spout.pending: null # TODO: We dont need this any more
topology.state.synchronization.timeout.secs: 60
-topology.stats.sample.rate: 0.05
+topology.stats.sample.rate: 0.001
--- End diff --
Yes I don't feel we need to change it if it's only for performance. We
already know the sampling rate affects performance, and tolerate it.
Btw, likewise I commented, I think we have touched so much variables
irrespective of the message subsystem and JCQueue. How you can prove
introducing JCQueue brings better throughput and/or lower latency in this
patch? How about message subsystem? Let's not touch variables and address them
in separate issue or patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
