Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129736199
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -269,11 +263,9 @@ public WorkerState(Map<String, Object> conf, IContext
mqContext, String topology
Map<String, Object> topologyConf, IStateStorage stateStorage,
IStormClusterState stormClusterState)
throws IOException, InvalidTopologyException {
this.executors = new
HashSet<>(readWorkerExecutors(stormClusterState, topologyId, assignmentId,
port));
- this.transferQueue = new DisruptorQueue("worker-transfer-queue",
+ this.transferQueue = new JCQueue("worker-transfer-queue",
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_TRANSFER_BUFFER_SIZE)),
- (long)
topologyConf.get(Config.TOPOLOGY_DISRUPTOR_WAIT_TIMEOUT_MILLIS),
-
ObjectReader.getInt(topologyConf.get(Config.TOPOLOGY_DISRUPTOR_BATCH_SIZE)),
- (long)
topologyConf.get(Config.TOPOLOGY_DISRUPTOR_BATCH_TIMEOUT_MILLIS));
+ 1); // TODO: Roshan: Is this the right batch size for
transferQueue ?
--- End diff --
actually this should be configurable. need to introduce a setting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
