Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r129763759
--- Diff:
storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -127,26 +154,30 @@ private void validate(Map<String, Object> topoConf,
Count windowLengthCount, Dur
throw new IllegalArgumentException("Window length is not
specified");
}
- if (windowLengthDuration != null && slidingIntervalDuration !=
null) {
- ensureDurationLessThanTimeout(windowLengthDuration.value +
slidingIntervalDuration.value, topologyTimeout);
- } else if (windowLengthDuration != null) {
- ensureDurationLessThanTimeout(windowLengthDuration.value,
topologyTimeout);
- } else if (slidingIntervalDuration != null) {
- ensureDurationLessThanTimeout(slidingIntervalDuration.value,
topologyTimeout);
- }
+ if (isPersistent()) {
+
ensureCheckpointIntervalLessThanTimeout(getCheckpointIntervalSecs(topoConf),
topologyTimeout);
--- End diff --
we don't need to validate `message timeout > window length + sliding
interval` here since the tuples are acked during checkpoint. Hence ensuring the
`timeout > checkpoint interval` would suffice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
