Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130227123
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WindowManager.java ---
@@ -111,14 +125,86 @@ public void add(Event<T> windowEvent) {
LOG.debug("Got watermark event with ts {}",
windowEvent.getTimestamp());
}
track(windowEvent);
- compactWindow();
+ if (!stateful) {
+ compactWindow();
+ }
}
/**
* The callback invoked by the trigger policy.
*/
@Override
public boolean onTrigger() {
+ return stateful ? doOnTriggerStateful() : doOnTrigger();
--- End diff --
I'm wondering if this would be nicer as a strategy or handled with an
abstract superclass?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
