Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2218#discussion_r130226940
--- Diff:
storm-client/src/jvm/org/apache/storm/windowing/WatermarkCountEvictionPolicy.java
---
@@ -17,20 +17,28 @@
*/
package org.apache.storm.windowing;
+import org.apache.storm.streams.Pair;
+
+import java.util.concurrent.atomic.AtomicLong;
+
/**
* An eviction policy that tracks count based on watermark ts and
* evicts events up to the watermark based on a threshold count.
*
* @param <T> the type of event tracked by this policy.
*/
-public class WatermarkCountEvictionPolicy<T> extends
CountEvictionPolicy<T> {
+public class WatermarkCountEvictionPolicy<T> implements EvictionPolicy<T,
Pair<Long, Long>> {
--- End diff --
Would it be possible to have this delegate to a CountEvictionPolicy instead
of having to duplicate parts of that class here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
