Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2253#discussion_r130801135 --- Diff: DEVELOPER.md --- @@ -214,14 +214,9 @@ To pull in a merge request you should generally follow the command line instruct $ git pull <remote_repo_url> <remote_branch> You can use `./dev-tools/storm-merge.py <pull-number>` to produce the above command most of the time. -4. Assuming that the pull request merges without any conflicts: - Update the top-level `CHANGELOG.md`, and add in the JIRA ticket number (example: `STORM-1234`) and ticket - description to the change log. Make sure that you place the JIRA ticket number in the commit comments where - applicable. +4. Run any sanity tests that you think are needed. --- End diff -- Right, that makes sense.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---