Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2248#discussion_r131020922 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -223,13 +237,25 @@ private void setPreparedStatementParams(PreparedStatement preparedStatement, Lis } } - private void closeConnection(Connection connection) { + private void closeConnection(Connection connection, Exception finalException) { if (connection != null) { try { connection.close(); } catch (SQLException e) { - throw new RuntimeException("Failed to close connection", e); + if (finalException != null) + { + LOG.error("Failed to close connection: " + e.getMessage()); + } --- End diff -- `else` after `}` with a space, `{` after `else` with a space.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---