Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2291#discussion_r134628949
  
    --- Diff: storm-client/test/jvm/org/apache/storm/TestConfigValidate.java ---
    @@ -84,21 +83,6 @@ public void invalidConfigTest() throws 
InvocationTargetException, NoSuchMethodEx
             ConfigValidation.validateFields(conf);
         }
     
    -    @Test(expected = InvalidTopologyException.class)
    --- End diff --
    
    I tried to mock it and then decided not to because the logic is really 
simple in `validateTopologyBlobStoreMap`. But I will add the unit test if you 
think it's better


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to