Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2271#discussion_r134874369
--- Diff: examples/storm-kafka-examples/pom.xml ---
@@ -43,19 +48,19 @@
<groupId>org.apache.storm</groupId>
<artifactId>storm-kafka</artifactId>
<version>${project.version}</version>
- <scope>${provided.scope}</scope>
+ <scope>${kafka.dependency.scope}</scope>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>${storm.kafka.artifact.id}</artifactId>
<version>${storm.kafka.version}</version>
- <scope>${provided.scope}</scope>
+ <scope>${kafka.dependency.scope}</scope>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
<version>${storm.kafka.version}</version>
- <scope>${provided.scope}</scope>
+ <scope>${kafka.dependency.scope}</scope>
--- End diff --
Sure, since storm-kafka-client-examples doesn't depend on
storm-kafka-examples anymore this isn't important. I'll change it to compile in
storm-kafka-client-examples too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
