Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2309#discussion_r137563632 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/WaterMarkEventGenerator.java --- @@ -126,4 +135,20 @@ private void checkFailures() { public void start() { this.executorFuture = executorService.scheduleAtFixedRate(this, interval, interval, TimeUnit.MILLISECONDS); } + + public void shutdown() { + LOG.debug("Shutting down WaterMarkEventGenerator"); + if (this.executorService != null) { --- End diff -- Nit: This doesn't seem like it can be null?
---