GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/2314
[STORM-2731] - Simple checks in Storm Windowing
There is also inconsistent and mixed used of Longs and Ints throughout the
windowing code. Perhaps we should just change all the numeric values to use
longs? Especially since all calculation of time is done in milliseconds. It
would also be nice to make clear in both the code and documentation that all
timestamps and time based calculations is in milliseconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2314
----
commit 40d133b6c9f434eabc3b50bb8f4ebf91d5999930
Author: Jerry Peng <[email protected]>
Date: 2017-09-07T22:32:39Z
[STORM-2731] - Simple checks in Storm Windowing
----
---
