Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2312#discussion_r138091077
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/topology/ComponentConfigurationDeclarer.java
 ---
    @@ -62,4 +69,14 @@
          * @return this for chaining.
          */
         T setNumTasks(Number val);
    +
    +    /**
    +     * Add generic resources for this component
    +     */
    +    T addResources(Map<String, Double> resources);
    +
    +    /**
    +     * Add generic resource for this component
    --- End diff --
    
    Just like with the javadocs it would be good to explain what keys are valid.


---

Reply via email to