Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2367#discussion_r144066568
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -53,8 +54,8 @@
public OffsetManager(TopicPartition tp, long initialFetchOffset) {
this.tp = tp;
this.initialFetchOffset = initialFetchOffset;
- this.committedOffset = initialFetchOffset - 1;
- LOG.debug("Instantiated {}", this);
+ this.committedOffset = initialFetchOffset;
+ LOG.debug("Instantiated {}", this.toString());
--- End diff --
This is not a big deal. But can you tell me what kinda warning you are
talking about? I never heard of such a thing. When you concatenate a string
with an object reference, the toString() method of that object reference is
called. I am not sure why both approaches are any different.
---
