Github user govind-menon commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2341#discussion_r144578588
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/messaging/netty/NettyUncaughtExceptionHandler.java
 ---
    @@ -33,10 +34,9 @@ public void uncaughtException(Thread t, Throwable e) {
     
             try {
                 Utils.handleUncaughtException(e);
    -        } catch (Throwable throwable) {
    -            LOG.error("Exception thrown while handling uncaught exception 
" + throwable.getCause());
    +        } catch (Error error) {
    +            LOG.error("Exception thrown while handling uncaught exception 
" + error.getCause());
    +            Runtime.getRuntime().exit(1);
             }
    -        LOG.info("Received error in netty thread.. terminating server...");
    --- End diff --
    
    It looks like the HashedWheelTimer will not be replaced - I'll take a 
second pass at this to confirm


---

Reply via email to