Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2379#discussion_r145976356
--- Diff:
storm-client/test/jvm/org/apache/storm/grouping/partialKeyGrouping/PartialKeyGroupingTest.java
---
@@ -53,7 +62,7 @@ public void testChooseTasksFields() {
PartialKeyGrouping pkg = new PartialKeyGrouping(new
Fields("test"));
WorkerTopologyContext context = mock(WorkerTopologyContext.class);
when(context.getComponentOutputFields(any(GlobalStreamId.class))).thenReturn(new
Fields("test"));
- pkg.prepare(context, mock(GlobalStreamId.class),
Lists.newArrayList(0, 1, 2, 3, 4, 5));
+ pkg.prepare(context, mock(GlobalStreamId.class),
Lists.newArrayList(9, 8, 7, 1, 2, 3));
--- End diff --
Why are we changing this? The test should still pass just fine with the
original values, and if not it is a bug. So why change them?
---
