Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2380#discussion_r146327143
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -78,17 +78,17 @@
private transient KafkaSpoutRetryService retryService;
// Handles tuple events (emit, ack etc.)
private transient KafkaTupleListener tupleListener;
- // timer == null for modes other than at-least-once
+ // timer == null if processing guarantee is other than at-least-once
private transient Timer commitTimer;
// Flag indicating that the spout is still undergoing initialization
process.
private transient boolean initialized;
// Initialization is only complete after the first call to
KafkaSpoutConsumerRebalanceListener.onPartitionsAssigned()
// Tuples that were successfully acked/emitted. These tuples will be
committed periodically when the commit timer expires,
- //or after a consumer rebalance, or during close/deactivate. Always
empty if not using at-least-once mode.
+ // or after a consumer rebalance, or during close/deactivate. Always
empty if not using at-least-once processing guarantee.
private transient Map<TopicPartition, OffsetManager> offsetManagers;
// Tuples that have been emitted but that are "on the wire", i.e.
pending being acked or failed.
- // Always empty if not using at-least-once mode.
+ // Always empty if processing guarantee is other than at-least-once.
--- End diff --
Same as for the timer comment
---
