Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r147234853
--- Diff: storm-client/src/jvm/org/apache/storm/Constants.java ---
@@ -56,5 +58,20 @@
public static final String STORM_ACTIVE_ATOM = "storm-active-atom";
public static final String COMPONENT_TO_DEBUG_ATOM =
"storm-component->debug-atom";
public static final Object LOAD_MAPPING = "load-mapping";
+
+ public static final String COMMON_CPU_RESOURCE_NAME =
"cpu.pcore.percent";
+ public static final String COMMON_ONHEAP_MEMORY_RESOURCE_NAME =
"onheap.memory.mb";
+ public static final String COMMON_OFFHEAP_MEMORY_RESOURCE_NAME =
"offheap.memory.mb";
+ public static final String COMMON_TOTAL_MEMORY_RESOURCE_NAME =
"memory.mb";
--- End diff --
Can we document these in some place? For example the configs show some
examples, but they are not exhaustive, and the rebalance command is really bad
at this so a user has no idea what to put in as the key.
---
