GitHub user lawrencecraft opened a pull request:
https://github.com/apache/storm/pull/2414
Fixing Java unit tests in storm-core to run under Windows (1.x branch)
While fixing STORM-2797 I noticed a bunch of the storm-core tests didn't
run under Windows.
I've fixed them up to use Windows-friendly asserts. All are done in a
generic way through framework classes except one particular case where the
behavior actually differs based on operating system. I only modified tests, not
any actual application code. I tested this change on Windows, OS X, and Linux:
all pass. On Windows, I still have to run Maven as administrator as some of the
tests write to temp folders in AppData.
I'll follow up with a pull request for STORM-2797. There are still some
Clojure tests failing but a lot of them are around the logviewer, which will be
fixed by my next PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lawrencecraft/storm WindowsTestFix-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2414
----
commit c32af1f4386044312357fe39c0789a41539aab6a
Author: Lawrence Craft <lawrence.cr...@gmail.com>
Date: 2017-11-11T16:21:14Z
Fixing Java unit tests in storm-core to run under Windows
----
---
