Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2203
  
    In case of missing, we have unaddressed comments in here:
    
https://github.com/apache/storm/blob/00a382b017c1e29863ac4d9a4449086ef79384e4/storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java#L133-L135
    
    and @revans2 had a voice regarding metadata of metrics, which IMHO looks 
like non-blocker for the patch, but if it makes sense we need to file a 
follow-up issue then.


---

Reply via email to