Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2443#discussion_r155647803
  
    --- Diff: sql/storm-sql-core/pom.xml ---
    @@ -66,10 +66,34 @@
                 <artifactId>calcite-core</artifactId>
                 <version>${calcite.version}</version>
                 <exclusions>
    +                <exclusion>
    --- End diff --
    
    Makes sense if we don't need them.
    
    If you're trying to avoid version conflicts for transitive dependencies I 
think adding a `<dependencyManagement>` section to set the versions is better. 
It lets you set which version of the dependency you want, and then all 
transitive includes of that dependency will be the specified version. I think 
we do this with e.g. the Jackson dependencies in the Storm parent pom.


---

Reply via email to