Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2443#discussion_r155672497
  
    --- Diff: 
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/spout/SocketSpout.java
 ---
    @@ -26,59 +27,61 @@
     import java.io.InputStreamReader;
     import java.net.Socket;
     import java.nio.ByteBuffer;
    -import java.util.ArrayList;
     import java.util.HashMap;
     import java.util.List;
     import java.util.Map;
    +import java.util.UUID;
     import java.util.concurrent.BlockingDeque;
     import java.util.concurrent.LinkedBlockingDeque;
     
     import org.apache.storm.Config;
     import org.apache.storm.spout.Scheme;
    +import org.apache.storm.spout.SpoutOutputCollector;
     import org.apache.storm.task.TopologyContext;
    -import org.apache.storm.trident.operation.TridentCollector;
    -import org.apache.storm.trident.spout.IBatchSpout;
    -import org.apache.storm.tuple.Fields;
    +import org.apache.storm.topology.IRichSpout;
    +import org.apache.storm.topology.OutputFieldsDeclarer;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     /**
    - * Trident Spout for Socket data. Only available for Storm SQL, and only 
use for test purposes.
    + * Spout for Socket data. Only available for Storm SQL. This doesn't 
guarantee at-least-once.
    --- End diff --
    
    I found myself dumb, I already implemented replay of messages.


---

Reply via email to