Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2454#discussion_r156208523
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -186,12 +182,13 @@ private void initialize(Collection<TopicPartition> 
partitions) {
                 for (TopicPartition tp : newPartitions) {
                     final OffsetAndMetadata committedOffset = 
kafkaConsumer.committed(tp);
                     final long fetchOffset = doSeek(tp, committedOffset);
    +                LOG.debug("Set consumer position to [{}] for 
topic-partition [{}], based on strategy [{}] and committed offset [{}]",
    --- End diff --
    
    Isn't this log message useful? I would suggest that unless this info is 
elsewhere, we leave this message. If you want it lower priority, we can put it 
as TRACE level.


---

Reply via email to