Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r158041504
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
    @@ -192,7 +240,7 @@ private TopologyContext mkTopologyContext(StormTopology 
topology) throws IOExcep
                         ConfigUtils.supervisorStormDistRoot(conf, 
workerData.getTopologyId())),
                         ConfigUtils.workerPidsRoot(conf, 
workerData.getWorkerId()),
                 taskId,
    -            workerData.getPort(), workerData.getTaskIds(),
    +            workerData.getPort(), workerData.getLocalTaskIds(),
    --- End diff --
    
    Renamed method looks better to clarify the meaning. Nice improvement.


---

Reply via email to