[GitHub] storm pull request #2476: Minor optimisation about trident kafka state

[OuYangLiang]

Github user OuYangLiang commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2476#discussion_r158179810
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
 ---
    @@ -116,8 +114,9 @@ public void updateState(List<TridentTuple> tuples, 
TridentCollector collector) {
                 }
     
                 if (exceptions.size() > 0) {
    -                StringBuilder errorMsg = new StringBuilder("Could not 
retrieve result for messages " + tuples + " from topic = " + topic
    -                    + " because of the following exceptions:" + 
System.lineSeparator());
    +                StringBuilder errorMsg = new StringBuilder("Could not 
retrieve result for messages ");
    --- End diff --
    
    There's a foreach statement right below it to iterate the exceptions, and 
append each exception to the errorMsg, it is still necessary I think.
    
    for (ExecutionException exception : exceptions) {
        errorMsg = 
errorMsg.append(exception.getMessage()).append(System.lineSeparator());
    }


---