[GitHub] storm pull request #2480: [WIP] STORM-2867: Add consumer lag metrics to Kafk...

[satishd]

Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r158660554
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
 ---
    @@ -212,6 +214,10 @@ boolean containsEmitted(long offset) {
             return emittedOffsets.contains(offset);
         }
     
    +    public long getLatestEmittedOffset() {
    +        return latestEmittedOffset;
    +    }
    +
         @Override
         public final String toString() {
             return "OffsetManager{"
    --- End diff --
    
    nit: Better to add `latestEmittedOffset` to toString.


---