Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2482#discussion_r158764626
--- Diff:
storm-client/src/jvm/org/apache/storm/metric/FileBasedEventLogger.java ---
@@ -59,8 +62,12 @@ private void initLogWriter(Path logFilePath) {
private void setUpFlushTask() {
- ScheduledExecutorService scheduler =
Executors.newSingleThreadScheduledExecutor();
- Runnable task = new Runnable() {
+ ThreadFactory threadFactory = new ThreadFactoryBuilder()
+ .setNameFormat("event-logger-flush-%d")
--- End diff --
I'm in favor of guaranteeing JVM shutdown in this case as I have seen
dangling worker scenarios are hard for users to debug and maintain.
---
