[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r159514108
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
    @@ -65,7 +66,7 @@
         private static final Object INTERRUPT = new Object();
         private static final String PREFIX = "disruptor-";
         private static final FlusherPool FLUSHER = new FlusherPool();
    -    private static final Timer METRICS_TIMER = new 
Timer("disruptor-metrics-timer", true);
    +    private static final ScheduledThreadPoolExecutor 
METRICS_REPORTER_EXECUTOR = new ScheduledThreadPoolExecutor(1);
    --- End diff --
    
    Thanks for replacing the Timer. If the threads for this still need to be 
daemon threads, you should use the constructor that takes a ThreadFactory, I 
believe the default factory produces non-daemon threads.


---