Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2494
  
    > e.g. If we rename the enum property AT_LEAST_ONCE to something else, only 
one file be affected.
    
    I don't think that's a concern, because we're very unlikely to do it. The 
enum values are part of the public API, so changing their names would be a 
breaking change.
    
    I don't think this change really makes the code better or more readable, 
just different. If we wanted to get rid of the utility isAtLeastOnceProcessing 
method in KafkaSpout, I'd rather we just replace the checks with 
`kafkaSpoutConfig.getProcessingGuarantee() == 
KafkaSpoutConfig.ProcessingGuarantee.AT_MOST_ONCE`.


---

Reply via email to