Github user ptgoetz commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r160777488
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -446,7 +451,7 @@
         (.ack spout msg-id)
         (task/apply-hooks (:user-context task-data) .spoutAck (SpoutAckInfo. 
msg-id task-id time-delta))
         (when time-delta
    -      (stats/spout-acked-tuple! (:stats executor-data) (:stream 
tuple-info) time-delta))))
    +      (stats/spout-acked-tuple! (:stats executor-data) 
(StormMetricRegistry/counter "acked" (:worker-context executor-data) 
(:component-id executor-data) (pr-str (:executor-id executor-data)) (:stream 
tuple-info)) (:stream tuple-info) time-delta))))
    --- End diff --
    
    @revans2 regarding map lookup, wouldn't we have to concatenate in order to 
create the lookup key?


---

Reply via email to