Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2475#discussion_r162313649
  
    --- Diff: storm-client/src/jvm/org/apache/storm/spout/ShellSpout.java ---
    @@ -177,6 +179,7 @@ private void handleMetrics(ShellMsg shellMsg) {
         private void querySubprocess() {
             try {
                 markWaitingSubprocess();
    +            _logHandler.setUpContext(_process, _context);
    --- End diff --
    
    This can be on-time setup, and maybe better to move this to `open()`, since 
we are more familiar with initializing everything in it.


---

Reply via email to