STORM-2918 has been merged to 1.x branch.
Now looks like we waiting for 1.x versions of https://github.com/apache/storm/pull/2538 and https://github.com/apache/storm/pull/2537 ? Can we get the next RC as soon as the above two are merged to 1.x ? Thanks, Arun On 2/1/18, 12:55 AM, "[email protected] on behalf of Artem Ervits" <[email protected] on behalf of [email protected]> wrote: >-1 >Please include https://issues.apache.org/jira/browse/STORM-2918 > >On Jan 31, 2018 1:59 PM, "Stig Rohde Døssing" <[email protected]> >wrote: > >> The log indicates a bug. We can remove the WARN messages pretty easily, but >> we'd still be throwing and catching an exception for each processed record. >> >> We're storing some data in Kafka alongside committed offsets that lets us >> only apply the EARLIEST and LATEST strategies for where the consumer should >> start if the topology is redeployed, rather than applying them every time >> the worker restarts. This was added as a fix to a bug I introduced in >> https://issues.apache.org/jira/browse/STORM-2666, where we error if the >> spout tries to emit offsets that have already been committed (that never >> happens during normal operation, but if the spout is restarted and using >> EARLIEST it can happen). The new behavior of EARLIEST/LATEST is also much >> more useful than the old one IMO. >> >> The bug is that we're only storing the metadata if the spout is configured >> for at-least-once. We also support at-most-once and an "anything goes" >> setting, and when either of those are used, the spout tries to read the >> metadata that isn't there and complains about it. If we just remove the >> log, EARLIEST and LATEST will behave differently for at-least-once and >> at-most-once/no-guarantee. >> >> The patch makes changes to ensure that we store metadata in all cases. >> >> 2018-01-31 19:47 GMT+01:00 Arun Mahadevan <[email protected]>: >> >> > Are we waiting for https://github.com/apache/storm/pull/2538 to start >> the >> > next RC ? >> > >> > This patch seem to contain more changes than just fixing a logging issue. >> > Can we only address the concern raised about logs filling with WARN >> > messages and address the rest in the next release or does the logs >> indicate >> > some bug which is a blocker for 1.2.0 ? >> > >> > - Arun >> > >> > >> > >> > >> > On 1/29/18, 12:30 PM, "P. Taylor Goetz" <[email protected]> wrote: >> > >> > >Cancelling this RC in order to address Stig’s concerns. >> > > >> > >-Taylor >> > > >> > >> On Jan 26, 2018, at 4:11 PM, P. Taylor Goetz <[email protected]> >> wrote: >> > >> >> > >> This is a call to vote on releasing Apache Storm 1.2.0 (rc2) >> > >> >> > >> Full list of changes in this release: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. >> > 2.0-rc2/RELEASE_NOTES.html >> > >> >> > >> The tag/commit to be voted upon is v1.2.0: >> > >> >> > >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h= >> > 17a4645d7d65f5a7a08a50b5185c0fc52e82692f;hb= >> 458aa1cb696097cf07d4466aa7417c >> > 7b89662221 >> > >> >> > >> The source archive being voted upon can be found here: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1. >> > 2.0-rc2/apache-storm-1.2.0-src.tar.gz >> > >> >> > >> Other release files, signatures and digests can be found here: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.2.0-rc2/ >> > >> >> > >> The release artifacts are signed with the following key: >> > >> >> > >> https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_ >> > plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd >> > >> >> > >> The Nexus staging repository for this release is: >> > >> >> > >> https://repository.apache.org/content/repositories/ >> orgapachestorm-1056 >> > >> >> > >> Please vote on releasing this package as Apache Storm 1.2.0. >> > >> >> > >> When voting, please list the actions taken to verify the release. >> > >> >> > >> This vote will be open for at least 72 hours. >> > >> >> > >> [ ] +1 Release this package as Apache Storm 1.2.0 >> > >> [ ] 0 No opinion >> > >> [ ] -1 Do not release this package because... >> > >> >> > >> Thanks to everyone who contributed to this release. >> > >> >> > >> -Taylor >> > > >> > >> > >>
