Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r166784163
--- Diff:
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
@@ -184,21 +184,21 @@
* daemons will cause it to fail.
* @param topologyId the id of the topology to scan.
*/
- void removeExpiredWorkerKeys(String topologyId);
+ void removeExpiredPrivateWorkerKeys(String topologyId);
/**
* Remove all of the worker keys for a given topology. Used to clean
up after a topology finishes.
* This is expected to only ever be called from nimbus and ideally
should only ever work from nimbus.
* @param topologyId the topology to clean up after.
*/
- void removeWorkerAllKeys(String topologyId);
+ void removeAllPrivateWorkerKeys(String topologyId);
/**
* Get a list of all topologyIds that currently have private worker
keys stored, of any kind.
* This is expected to only ever be called from nimbus.
* @return the list of topology ids with any kind of private worker
key stored.
*/
- Set<String> workerTokenTopologyKeys();
+ Set<String> idsOfTopologysWithPrivateWorkerKeys();
--- End diff --
nit: Topologies
---
