Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2502#discussion_r167287393 --- Diff: storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -40,109 +40,117 @@ import org.apache.storm.nimbus.NimbusInfo; public interface IStormClusterState { - public List<String> assignments(Runnable callback); + List<String> assignments(Runnable callback); - public Assignment assignmentInfo(String stormId, Runnable callback); + Assignment assignmentInfo(String stormId, Runnable callback); - public VersionedData<Assignment> assignmentInfoWithVersion(String stormId, Runnable callback); + VersionedData<Assignment> assignmentInfoWithVersion(String stormId, Runnable callback); - public Integer assignmentVersion(String stormId, Runnable callback) throws Exception; + Integer assignmentVersion(String stormId, Runnable callback) throws Exception; - public List<String> blobstoreInfo(String blobKey); + List<String> blobstoreInfo(String blobKey); - public List<NimbusSummary> nimbuses(); + List<NimbusSummary> nimbuses(); - public void addNimbusHost(String nimbusId, NimbusSummary nimbusSummary); + void addNimbusHost(String nimbusId, NimbusSummary nimbusSummary); - public List<String> activeStorms(); + List<String> activeStorms(); /** * Get a storm base for a topology * @param stormId the id of the topology * @param callback something to call if the data changes (best effort) * @return the StormBase or null if it is not alive. */ - public StormBase stormBase(String stormId, Runnable callback); + StormBase stormBase(String stormId, Runnable callback); - public ClusterWorkerHeartbeat getWorkerHeartbeat(String stormId, String node, Long port); + ClusterWorkerHeartbeat getWorkerHeartbeat(String stormId, String node, Long port); - public List<ProfileRequest> getWorkerProfileRequests(String stormId, NodeInfo nodeInfo); + List<ProfileRequest> getWorkerProfileRequests(String stormId, NodeInfo nodeInfo); - public List<ProfileRequest> getTopologyProfileRequests(String stormId); + List<ProfileRequest> getTopologyProfileRequests(String stormId); - public void setWorkerProfileRequest(String stormId, ProfileRequest profileRequest); + void setWorkerProfileRequest(String stormId, ProfileRequest profileRequest); - public void deleteTopologyProfileRequests(String stormId, ProfileRequest profileRequest); + void deleteTopologyProfileRequests(String stormId, ProfileRequest profileRequest); - public Map<ExecutorInfo, ExecutorBeat> executorBeats(String stormId, Map<List<Long>, NodeInfo> executorNodePort); + Map<ExecutorInfo, ExecutorBeat> executorBeats(String stormId, Map<List<Long>, NodeInfo> executorNodePort); - public List<String> supervisors(Runnable callback); + List<String> supervisors(Runnable callback); - public SupervisorInfo supervisorInfo(String supervisorId); // returns nil if doesn't exist + SupervisorInfo supervisorInfo(String supervisorId); // returns nil if doesn't exist - public void setupHeatbeats(String stormId); + void setupHeatbeats(String stormId); - public void teardownHeartbeats(String stormId); + void teardownHeartbeats(String stormId); - public void teardownTopologyErrors(String stormId); + void teardownTopologyErrors(String stormId); - public List<String> heartbeatStorms(); + List<String> heartbeatStorms(); - public List<String> errorTopologies(); + List<String> errorTopologies(); - public List<String> backpressureTopologies(); + /** @deprecated: In Storm 2.0. Retained for enabling transition from 1.x. Will be removed soon. */ --- End diff -- Could you file a JIRA for us to remove it in 3.x?
---