[GitHub] storm pull request #2502: new PR for STORM-2306 : Messaging subsystem redesi...

[roshannaik]

Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r167800249
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/trident/spout/RichSpoutBatchExecutor.java 
---
    @@ -194,7 +194,12 @@ public void reportError(Throwable t) {
             public void emitDirect(int task, String stream, List<Object> 
values, Object id) {
                 throw new UnsupportedOperationException("Trident does not 
support direct streams");
             }
    -        
    +
    +        @Override
    +        public void flush() {
    +            //NOOP   //TODO: Roshan: validate if this is OK
    --- End diff --
    
    needs to flush.


---