GitHub user reiabreu opened a pull request:
https://github.com/apache/storm/pull/2593
STORM-2994 KafkaSpout commit offsets for null tuples
Hello,
Let's kick off this pull request.
Unit tests for null tuples were missing. I'm in the process of adding them.
I'll update this PR asap. Meanwhile, these seem to be the necessary changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reiabreu/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2593
----
commit 1db31bcf784a69d3904f39d86d8987f3c9e5e4bd
Author: Rui Abreu <rui.abreu@...>
Date: 2018-03-16T12:50:11Z
null tuples are now marked as emitted and marked as acked
commit 59235e79d64b8888b0190bf1b9364066215f3650
Author: Rui Abreu <rui.abreu@...>
Date: 2018-03-17T11:09:08Z
Undoing import statements changes
----
---
