Github user krichter722 commented on the issue:

    https://github.com/apache/storm/pull/2595
  
    > Some other changes were made to these files. Could you fix up eol again?
    
    Done.
    
    > Regarding the text=auto for all paths, I'm mentioning it because googling 
text=auto brings up instances where git guessed wrong and broke some people's 
png files. I think it would be easier to just exclude file types we obviously 
don't want to fix eol for now, rather than someone having to debug it later.
    
    In such cases it's always save to assume that sharing your research helps 
others. I found an [issue mentioning incorrect detection of files unrelated to 
their type which is fixed in git 
2.10](https://stackoverflow.com/questions/29435156/what-will-text-auto-eol-lf-in-gitattributes-do),
 but I added `*.png binary` and an explanation anyway - why take the risk?


---

Reply via email to