Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r177711557
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/cluster/IStormClusterState.java ---
    @@ -42,16 +42,44 @@
     public interface IStormClusterState {
         List<String> assignments(Runnable callback);
     
    +    /**
    +     * Get the assignment based on storm id from local backend.
    +     * @param stormId topology id
    +     * @param callback callback function
    +     * @return {@link Assignment}
    +     */
         Assignment assignmentInfo(String stormId, Runnable callback);
     
    +    /**
    +     * Get the assignment based on storm id from remote state store, eg: 
ZK.
    +     * @param stormId topology id
    +     * @param callback callback function
    +     * @return
    --- End diff --
    
    nit: `@return {@link Assignment}`


---

Reply via email to