Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2619#discussion_r178455098
  
    --- Diff: conf/defaults.yaml ---
    @@ -195,7 +195,7 @@ worker.log.level.reset.poll.secs: 30
     # control how many worker receiver threads we need per worker
     topology.worker.receiver.thread.count: 1
     
    -# Executor metrics reporting interval.
    +# Executor metrics reporting interval, keep default val same with 
topology.builtin.metrics.bucket.size.secs
    --- End diff --
    
    Thanks, but I meant add a note to the comment. I can't tell from the 
current comment why the two properties need to be in sync, so I'd have to look 
up this PR to see why.


---

Reply via email to