Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2625#discussion_r179931937
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -599,20 +613,16 @@ public WorkerTopologyContext
getWorkerTopologyContext() {
public void runWorkerStartHooks() {
WorkerTopologyContext workerContext = getWorkerTopologyContext();
if (topology.is_set_worker_hooks()) {
- for (ByteBuffer hook : topology.get_worker_hooks()) {
- byte[] hookBytes = Utils.toByteArray(hook);
- BaseWorkerHook hookObject =
Utils.javaDeserialize(hookBytes, BaseWorkerHook.class);
- hookObject.start(topologyConf, workerContext);
+ for (IWorkerHook hook : getDeserializedWorkerHooks()) {
+ hook.start(topologyConf, workerContext);
}
}
}
public void runWorkerShutdownHooks() {
if (topology.is_set_worker_hooks()) {
--- End diff --
if statement unnecessary for now.
---
