GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2653
[WIP] Detach storm-kafka-client release from Storm proper
Opening this to get feedback on detaching the storm-kafka-client release
cycle from Storm, as discussed on the mailing list. I'm putting this up so we
can get an idea what we need to do to detach storm-kafka-client from Storm's
release cycle, before we decide whether we want to try it.
I've made the following changes:
* Detached storm-kafka-client from Storm. It still uses the Storm parent
POM, but is otherwise an independent project
* Copied the release_notes script so we can generate release notes for
storm-kafka-client. Exclude storm-kafka-client issues from Storm release notes
* Addded a set of profiles to the storm-kafka-client POM so we can build
against both Storm 1.x and 2.x. We can build against 1.x by doing e.g. `mvn
clean install -Dstorm.release.line=1.x -Dstorm.version=1.2.2-SNAPSHOT`
* Reverted to raw maps in e.g. the spout open method. Having the generic
types is nice, but prevents the spout from running on 1.x.
I ran into two API issues against Storm 1.x when trying to get this version
running on both 1.x and 2.x. One is the map generics mentioned above, the other
is a change I'd like to backport to 1.x here
https://github.com/apache/storm/pull/2650. The issue is the type of the third
parameter to IOpaquePartitionedTridentSpout.Emitter.getPartitionsForTask, which
was changed in master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm detach-kafka-client
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2653
----
commit 5e4efddf9deb1381ff4f237df2e08e96eb4f74b9
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-05-01T17:14:56Z
Detach storm-kafka-client from main Storm project, make storm projects
using storm-kafka-client point to 2.0.0-SNAPSHOT until the first release, copy
release notes script for use during storm-kafka-client release
commit 79d28a132eb8a6ca1d4a455c9fb77f2ea981fb8c
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-05-01T18:21:09Z
Remove generic types in a few places to be compatible with Storm 1.x
----
---
