Github user Ethanlm commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2657#discussion_r186173164
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/ConstraintSolverStrategy.java
 ---
    @@ -98,6 +98,7 @@ public static boolean validateSolution(Cluster cluster, 
TopologyDetails td) {
          */
         private static boolean checkConstraintsSatisfied(Cluster cluster, 
TopologyDetails topo) {
             LOG.info("Checking constraints...");
    +        assert(cluster.getAssignmentById(topo.getId())!=null);
    --- End diff --
    
    nit: space before and after `!=`.  same for the below code changes. 


---

Reply via email to