Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2669
As far as I can tell all connections are still being shut down with this
change. The connections cached by WorkerState are closed during worker shutdown
in
https://github.com/apache/storm/blob/14b0b4fc5e0945456769fd58a3595188e3dea234/storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java#L449,
and the context is shut down a few lines further down.
The WorkerState.refreshConnections method also makes sure to never create a
connection for a NodeInfo that is already present, so I don't think we're
leaking connections there that would need to be picked up by context.term.
Would like to see the cleanup @revans2 mentioned, as well as a change in
the IContext docs so it's specified that the created connections are new.
---
