Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2733#discussion_r197831240
  
    --- Diff: dev-tools/travis/travis-script.sh ---
    @@ -31,7 +31,14 @@ else
       # Travis only has 3GB of memory, lets use 1GB for build, and 1.5GB for 
forked JVMs
       export MAVEN_OPTS="-Xmx1024m"
       
    -  mvn --batch-mode test -fae -Pnative,all-tests '-P!include-shaded-deps' 
-Prat -pl "$2"
    +  TEST_MODULES=$2
    +  
    +  if [ "$TRAVIS_JDK_VERSION" == "oraclejdk10" ] && [ "$TEST_MODULES" == 
"'!storm-client,!storm-server,!storm-core'" ]
    +  then 
    +    TEST_MODULES = 
'!storm-client,!storm-server,!storm-core,!external/storm-cassandra,!external/storm-hive'
    --- End diff --
    
    We have overloaded TEST_MODULES from being a pass-through to maven already 
for integration tests, lets just bite the bullet and turn it into an enum 
instead, so it is not as unexpected.


---

Reply via email to