[GitHub] storm pull request #2751: STORM-3142: Add JUnit 5 support, migrate a couple ...

[srdo]

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2751

    STORM-3142: Add JUnit 5 support, migrate a couple of tests in storm-k…

    …afka-client to check that both JUnit 5 and 4 work. Also fix 
storm-kafka-client tests so they delete their temporary directories when done 
testing.
    
    https://issues.apache.org/jira/browse/STORM-3142
    
    I checked that stuff like `@Category` exclusion still works. As far as I 
can tell all the existing tests run fine with this.
    
    I switched some tests in storm-kafka-client to the JUnit 5 API to verify 
that we can use both APIs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2751
    
----
commit c14a9b53f2aa68c161063a5a5e141c4eab0356bb
Author: Stig Rohde Døssing <srdo@...>
Date:   2018-07-04T15:11:59Z

    STORM-3142: Add JUnit 5 support, migrate a couple of tests in 
storm-kafka-client to check that both JUnit 5 and 4 work. Also fix 
storm-kafka-client tests so they delete their temporary directories when done 
testing.

----


---