Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2761#discussion_r202070445
--- Diff: storm-client/src/storm.thrift ---
@@ -206,10 +206,8 @@ struct NimbusSummary {
struct ClusterSummary {
1: required list<SupervisorSummary> supervisors;
- //@deprecated, please use nimbuses.uptime_secs instead.
- 2: optional i32 nimbus_uptime_secs = 0;
- 3: required list<TopologySummary> topologies;
- 4: required list<NimbusSummary> nimbuses;
+ 2: required list<TopologySummary> topologies;
+ 3: required list<NimbusSummary> nimbuses;
--- End diff --
Can we please follow the guidelines for maintaining wire compatibility?
this way old clients still have a chance of working with the newer servers.
```
struct ClusterSummary {
1: required list<SupervisorSummary> supervisors;
// removed (DO NOT REUSE) 2:
3: required list<TopologySummary> topologies;
4: required list<NimbusSummary> nimbuses;
}
```
---
