Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2443#discussion_r202358383
  
    --- Diff: 
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
 ---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + *
    + */
    +
    +package org.apache.storm.sql.runtime.datasource.socket.bolt;
    +
    +import java.io.BufferedWriter;
    +import java.io.IOException;
    +import java.io.OutputStreamWriter;
    +import java.net.Socket;
    +import java.util.Map;
    +
    +import org.apache.storm.shade.org.apache.commons.io.IOUtils;
    +import org.apache.storm.sql.runtime.IOutputSerializer;
    +import org.apache.storm.task.OutputCollector;
    +import org.apache.storm.task.TopologyContext;
    +import org.apache.storm.topology.IRichBolt;
    +import org.apache.storm.topology.OutputFieldsDeclarer;
    +import org.apache.storm.tuple.Tuple;
    +import org.apache.storm.tuple.Values;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +/**
    + * The Bolt implementation for Socket. Only available for Storm SQL.
    + * The class doesn't handle reconnection so you may not want to use this 
for production.
    --- End diff --
    
    Does it make sense for us to include code like this if we know it isn't 
suitable for production use? 


---

Reply via email to