Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2752#discussion_r204262044
--- Diff:
storm-core/src/jvm/org/apache/storm/ui/filters/HeaderResponseServletFilter.java
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.ui.filters;
+
+import com.codahale.metrics.Meter;
+import org.apache.storm.Constants;
+import org.apache.storm.metric.StormMetricsRegistry;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.servlet.Filter;
+import javax.servlet.FilterChain;
+import javax.servlet.FilterConfig;
+import javax.servlet.ServletException;
+import javax.servlet.ServletRequest;
+import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import java.io.IOException;
+
+public class HeaderResponseServletFilter implements Filter {
+ public static final Logger LOG =
LoggerFactory.getLogger(HeaderResponseServletFilter.class);
+
+ public static Meter webRequestMeter =
+ StormMetricsRegistry.registerMeter("num-web-requests");
+
+ public static Meter mainPageRequestMeter =
+
StormMetricsRegistry.registerMeter("ui:num-main-page-http-requests");
+ @Override
+ public void init(FilterConfig filterConfig) throws ServletException {
+
+ }
+
+ @Override
+ public void doFilter(ServletRequest servletRequest, ServletResponse
servletResponse, FilterChain filterChain) throws IOException, ServletException {
+ webRequestMeter.mark();
+ HttpServletRequest httpRequest = (HttpServletRequest)
servletRequest;
+ HttpServletResponse httpResponse = (HttpServletResponse)
servletResponse;
+ if ((httpRequest.getPathInfo()).equals("/index.html")) {
--- End diff --
It looks like porting `request-middleware` to filter and the conditions
between `request-middleware` and here are not same.
https://github.com/apache/storm/blob/a7e817bcd1424d300ab5bad06c5d9f4729d9f347/storm-core/src/clj/org/apache/storm/ui/helpers.clj#L39-L55
---
