[GitHub] storm pull request #2771: STORM-3157: General improvement to StormMetricsReg...

[zd-project]

Github user zd-project commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2771#discussion_r204917201
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java 
---
    @@ -312,7 +315,7 @@ public void launchDaemon() {
                 launch();
                 Utils.addShutdownHookWithForceKillIn1Sec(this::close);
     
    -            registerWorkerNumGauge("supervisor:num-slots-used-gauge", 
conf);
    +            registerGauge(name(SUPERVISOR, "num-slots-used-gauge"), () -> 
SupervisorUtils.supervisorWorkerIds(conf).size());
    --- End diff --
    
    Okay will refactor this.


---