GitHub user mal opened a pull request:

    https://github.com/apache/storm/pull/2779

    STORM-3163: Make ShellBolt logger thread local to support MDC

    Prior to this the logger set up and use would occur in separate threads,
    so any MDC values would not persist from set up, by using the same
    thread, MDC values are now reliably available during log calls.
    
    https://issues.apache.org/jira/browse/STORM-3163
    
    ---
    
    _P.S._ While working on this, I also ended up pulling the log level routing 
out of `DefaultShellLogHandler` as this makes it trivial to reuse in customised 
`ShellLogHandler`s.
    
    ---
    
    Currently WIP, early feedback welcome, tests to follow 🙂 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mal/storm STORM-3163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2779
    
----
commit 333effcd77dc01e9342ffdebbb35748c9ff79dc8
Author: Mal Graty <mal.graty@...>
Date:   2018-07-29T15:06:51Z

    Make ShellBolt logger thread local to support MDC
    
    Prior to this the logger set up and use would occur in separate threads,
    so any MDC values would not persist from set up, by using the same
    thread MDC values are now reliably available during log calls.

----


---

Reply via email to